Lynx Smart Contract Security Review

These functions are onlyOwner and nonReentrant. The external caller is the configured SaucerSwap NFT manager — a trusted protocol contract, not arbitrary users. There is no practical reentrancy attack path for depositors; reordering to strict checks-effects-interactions would be a style improvement, not a security fix.

The vault and bridge must receive HBAR for depositHbar and depositHbarAndWrap. The LP strategy holds HBAR for SaucerSwap V2 NFT mint/increase fees. User funds are not trapped — the missing sweep only affects residual operational dust, which governance can recover later if needed.

The recipient is a governance-configured WHBAR helper contract, not an arbitrary user address. This is required for the staking harvest unwrap/wrap path. Access is keeper-only on the harvest functions.

False positive. FullMath is the standard Uniswap V3 library; the flagged operator is bitwise XOR in fixed-point math, not Solidity exponentiation. Included in scope for LP mark-to-market helpers only.

Accepted. _findAvailableSecond uses bounded prevrandao jitter to discover HIP-1215 schedule slots. Failure is non-reverting with ScheduleFailed events; health CI monitors mirror logs.

Resolved by emitting HarvestCompleted events that include the manager return values. Closes the unused-return finding; +2 Low reentrancy-events on the same paths are accepted (observability events post-call).

Resolved by adding LpAllocatorSet event on setLpAllocator. Improves ops observability and closes the Aderyn L-7 theme.

Resolved by LynxLpAllocator fail-fast reverts: SwapProducedZero when swap output is zero, LiquidityIncreaseZero when liquidity increase is zero on the active deploy path.

Resolved by typing DEFAULT_LP_DRAIN_DUST as uint128 at declaration. Closes the H-4 unsafe-cast theme from the prior snapshot.

Resolved with explicit local initializers in LynxKeeperRouter.reconcileInactiveLp and cached targets.length in LynxLpAllocator.deployLpIdle.

HtsOps checks HederaResponseCodes.SUCCESS internally and reverts with HTSCallFailed on failure. Callers do not need to re-check the int64 return value — the library already enforces success or revert.

Profit streaming (Yearn-style linear unlock) deliberately uses timestamps so depositors cannot sandwich harvests. On Hedera, consensus timestamps have narrow skew (~10–15s), which is negligible for hour/day unlock periods set by governance.

The manager must observe strategy return values before adjusting principal or reporting PnL — reversing the order would break accounting. Access is keeper-only with nonReentrant; push was reordered to CEI, but pull/harvest order is intentional.

This is the protocol trust model, not a code bug. Mitigations include Ownable2Step (two-step ownership transfer), optional guardian for fast pause, exit/redemption paths that stay open when inflows are paused, MAX_EXIT_FEE_BPS ceiling, and per-strategy caps. Production governance is expected to be a multisig.

Accepted. Leading calls validate strategyManager matches the vault before registration — a hardening guard against miswired strategies. No user funds at risk; only governance can register.

Accepted. Same pattern as bookLoss — keeper-only, nonReentrant manager path. Books NAV loss when principal exceeds on-chain exposureValue(); required for exposure-cap hardening.

Zero means “not configured yet.” All mutating LP functions revert with NotConfigured() until the admin sets real SaucerSwap router and NFT manager addresses. This is an intentional two-phase setup pattern.

Clearing the guardian is intentional — it disables guardian-only pause so only the owner can pause. Documented in NatSpec. Useful when rotating or removing the guardian role without transferring ownership.

These are Hedera HTS precompile calls at 0x167, not standard ERC20 transfer/approve with boolean return values. Aderyn’s ERC20 checker does not apply to HTS semantics.

evmVersion: cancun is pinned in Hardhat and Foundry profiles to match Hedera mainnet (Besu EVM, release 0.50.0+). PUSH0 is expected and required for Cancun-targeted deployments.

asset() is implemented via override resolving both ERC4626 and ILynxVault in LynxVault.sol. Slither’s inheritance analysis missed the dual-interface override.

10_000 is the standard basis-points denominator (100.00%). Named constant improves readability; no security impact.

Modifier ordering on owner-only admin functions has no demonstrated security impact. nonReentrant is still applied; reordering would be cosmetic.

CI compiles all contracts with solc 0.8.28. The broad pragma allows compatibility; the pinned compiler version in CI is what matters for deployment.

Paths are access-controlled (keeper or owner only). push was hardened with checks-effects-interactions (principal booked before external calls). No user-facing reentrancy surface.

Events are emitted after external harvest calls for observability. No state corruption — harvest functions are access-controlled and the events document manager return values intentionally.

Deadline uses block.timestamp + buffer — standard swap deadline pattern. Hedera consensus timestamp skew is negligible for LP deploy timeouts.

Accepted by design. address(0) disables split-router alignment checks — same intentional pattern as setGuardian(0) for clearing optional wiring.

Accepted. Retroactive ops wiring for existing LP positions; optional event can be added in a future version. No depositor-facing exploit path.

Pragma updated to ^0.8.28 aligned with the rest of the stack. CI compiles with solc 0.8.28 — the warning is resolved in the current codebase.